Repository navigation
chore: fix Dependabot alerts and update examples to latest - #420
Merged
Merged
Conversation
Update every workspace dependency within its current major and refresh the lockfile. Raise the override floors for vite, undici and follow-redirects and add one for source-map-js, so the lockfile no longer resolves any version Dependabot flags. deepmerge has no patched release and only comes in through jest. lerna 10.1.1 moves to sigstore 5, so the provenance patch moves to sigstore@5.0.1: @sigstore/sign now defaults fetchOnConflict to true, but sigstore still passes false explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Declare every example dependency as "latest": Dependabot never raised an alert on those manifests, while ranges kept raising alerts on code that never runs. storybook-legacy stays on Storybook 8 (storycap supports nothing newer) and remix on React 18 (Remix v2 caps it). Migrate the examples to the current majors (Next 16, Tailwind 4, React Router 8, Storybook 10, WebdriverIO 10) and check that each one installs and captures Argos screenshots. Along the way: - drop ESLint and template leftovers unrelated to Argos - use @argos-ci/webdriverio in the WebdriverIO example - run Puppeteer headless - fix Remix's start script and load its stylesheet - fix React Router's Playwright webServer port - use npm install and actions v7 in example workflows - point README links to argos-javascript examples Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the open Dependabot alerts and brings every example up to date.
Workspace dependencies
pnpm-lock.yaml. No major bumps.vite(^7.3.7),undici(^8.12.2) andfollow-redirects(^1.16.1), and addedsource-map-js(^1.2.2): these were held on vulnerable versions.pnpm-lock.yaml: 56 no longer match. The remaining one isdeepmerge, which has no patched release and only comes in through jest.sigstore@5.0.1. Recover Rekor duplicate-entry conflicts by default sigstore/sigstore-js#1708 madefetchOnConflict: truethe default in@sigstore/sign, butsigstore5.0.1 still passesfalseexplicitly, so the patch is still needed.Examples
The 14 open example alerts were dismissed as "Vulnerable code is not actually used". To stop new ones, every example dependency is now
"latest": no example manifest using"latest"has ever raised an alert, while ranges and pins kept raising them (34 onexamples/nextjsalone). Two exceptions can still alert:storybook-legacystays on Storybook^8.6.19and vite^6.4.6, because storycap supports nothing newer than Storybook 8.remixstays on React^18, because Remix v2 caps it.Each example was migrated to the current majors (Next 16, Tailwind 4, React Router 8, Storybook 10, WebdriverIO 10). It was then installed fresh outside the repo and run end to end, and it wrote Argos screenshots. Nothing was uploaded. Along the way:
@argos-ci/webdriverioinstead of plainsaveScreenshot; its config went from 289 lines to 27.startscript (it crashed) and loaded its stylesheet, which was never linked.webServer: it started the dev server on 5173 but waited for port 3000.npm install, since there's no lockfile, and actions v7.upload-artifact@v3no longer works.argos-ci/argos/tree/main/examples.Type of changes
Maintenance: dependencies and examples.
Checklist
build,check-types,lint,check-formatandtest, plus the Playwright, Vitest, Storybook (Vitest and test-runner), Cypress, Puppeteer and WebdriverIO e2e suites with upload off.Further comments
examples/react-routercovers the same setup, so the Remix example could be retired../screenshots. With the Argos reporter set up, they're written undertest-results/.🤖 Generated with Claude Code